Updates for Simplex implementation#69
Merged
bvscd merged 1 commit intorelease/node/v0.5.0from Apr 8, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request implements major updates to the Simplex consensus protocol implementation, transitioning from a get_committed_candidate callback-based approach to a finalized-driven delivery model via on_block_finalized(). The changes affect multiple layers of the validator infrastructure including listener interfaces, session management, and network context handling.
Changes:
- Replace
get_committed_candidatewithon_block_finalizedcallback for finalized block delivery - Implement
OnAppliedTopaction type for spreading MC-applied-top information to simplex sessions - Refactor validator list network readiness tracking from
network_readyflag to context-based checking - Remove
RestartRecommitStrategyenum and simplify startup recovery - Update
ValidatorListOutcometo removenetwork_readyfield and check context separately - Add extensive simplex state refactoring and timing fixes
- Implement standstill recovery and egress budget management
Reviewed changes
Copilot reviewed 41 out of 43 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/node/src/validator/validator_session_listener.rs |
Replaces OnGetCommittedCandidate with OnAppliedTop and OnBlockFinalized enum variants and implements corresponding handler |
src/node/src/validator/validator_manager.rs |
Refactors validator list network readiness tracking; updates notify_simplex_sessions_applied_tops function; implements applied-top-based session management |
src/node/src/validator/validator_group.rs |
Adds on_block_finalized method for out-of-order finalized block delivery; adds test for sync_last_accepted_mc_seqno_from_applied_top |
src/node/src/validator/consensus.rs |
Updates notify_mc_finalized to use BlockIdExt instead of seqno; removes CommittedBlockProof imports |
src/node/src/network/node_network.rs |
Adds resolve_validator_adnl_key method; updates overlay peer addition logic; adds has_validator_list_context method |
src/node/src/engine_traits.rs |
Removes network_ready field from ValidatorListOutcome; adds has_validator_list_context method to PrivateOverlayOperations |
src/node/simplex/src/lib.rs |
Removes RestartRecommitStrategy enum; updates on_block_finalized documentation throughout |
| Simplex tests | Updates test listeners to implement on_block_finalized instead of old callback paths; refactors seqno tracking |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.